-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote better deprecation communication and compatibility #3261
Conversation
@thisisdano on a Do you have any thoughts on possibly moving the changelog message as a gulp task and maybe we can take advantage of: const log = require('fancy-log');
const c = require('ansi-colors'); |
It would yeah — I don't think I know how to make run only once. I do worry that it's too "heavy", but I also think that's important to get a notification in the build process in addition to release notes, etc. Perhaps there is a better way? For me, the downside to a gulp-based solution is it's too tied to The upside it it looks less like an error and could maybe have more sophisticated logic. Even so, I'm inclined to keep it in Sass. |
Perhaps this needs more time to bake and we should wait for a later release |
On second thought, I think this is better to get in right now. Then we can work to improve it. |
No sir, seems good to go. I'll see if I can prototype something on my end and see how/if we can improve. But as of now, you're right. It's good info for users. |
We're handling deprecations more gracefully. Occasionally the design system will deprecate variables or functionality. Now we'll display a deprecation message in the terminal when compiling USWDS Sass to better communicate these changes. We're also improving backward compatibility by supporting deprecated variables, functions, and mixins throughout the major version cycle. This way, we can continue to improve how our code is structured while minimizing the effects of this restructuring on your projects.
This is how the deprecation warning prints in the terminal:
Success criteria
Fixes #3254